Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1599 Fix test 'testContinueSoundDoesNotStartFromBeginning' #4995

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dajminks
Copy link

@dajminks dajminks commented May 31, 2024

Will change the existing flaky test. Instead of checking if some specific time of the Sound passed, it checks if after the transition the currentTime is bigger or equal then it was before the transition. The wait brick is bigger then before so the sound can start play.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@dajminks dajminks closed this May 31, 2024
@dajminks dajminks reopened this May 31, 2024
Copy link
Contributor

@JayTropper JayTropper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine

Copy link
Contributor

@reichli reichli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a look at this together.
Your changes improved the situation, but we are not quite there yet. Locally the last assertion still gives me 0 >= 0. I commented out the code that this test is supposed to cover and it did not fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants