Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLOCKS-345 update gh actions to node18 #436

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

BLOCKS-345 update gh actions to node18 #436

wants to merge 1 commit into from

Conversation

MichaelFlucher
Copy link
Member

@MichaelFlucher MichaelFlucher commented Jun 17, 2023 •
edited
Loading

https://jira.catrob.at/browse/BLOCKS-345
update nodejs version of docker containers and gh actions

Your checklist for this pull request

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Make sure you use BLOCKS instead of CATROID in your commit message
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed (Actions)
  • Post a message in the #catblocks Slack channel and ask for a code reviewer

bprattes
bprattes approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@bprattes bprattes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greilberger13 greilberger13 self-requested a review October 12, 2023 17:38
greilberger13
greilberger13 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@greilberger13 greilberger13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprattes bprattes bprattes approved these changes

@greilberger13 greilberger13 greilberger13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelFlucher @bprattes @greilberger13 @catrobat-github-bot