Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shortcut not working (probably related to Android 5.0.2) #687

Open
Altonss opened this issue Dec 15, 2021 · 2 comments
Open

Update shortcut not working (probably related to Android 5.0.2) #687

Altonss opened this issue Dec 15, 2021 · 2 comments
Labels
android: 5 common: occasional Affects or can be seen by some users regularly or most users rarely severity: major Severely degrades major functionality or product features, with no satisfactory workaround state: help wanted I looked into this issue but couldn't solve it quickly type: bug Something isn't working

Comments

@Altonss
Copy link
Contributor

Altonss commented Dec 15, 2021

The updating of the card shortcuts does not work on my Android 5.0.2.

  1. Create a shortcut for a card named "Clothing store"
  2. Rename the card to "test" -> shortcut not changed
  3. Changed the card image -> shortcut not changed
@TheLastProject TheLastProject added type: bug Something isn't working android: 5 state: help wanted I looked into this issue but couldn't solve it quickly labels Dec 16, 2021
@TheLastProject TheLastProject added common: occasional Affects or can be seen by some users regularly or most users rarely severity: major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 5, 2022
@Altonss
Copy link
Contributor Author

Altonss commented Jul 24, 2022

Is this working on newer versions of Android? Because for the PR #669 I need to implement this for groups, but currently only have an Android 5 device for testing. While looking at the code of https://github.com/CatimaLoyalty/Android/blob/master/app/src/main/java/protect/card_locker/ShortcutHelper.java I've found nothing indicating an update mechanisme for the title of the card and the icon...

@TheLastProject
Copy link
Member

I can confirm it works fine on Android 11:

document_5978585997766560986.mp4

While I don't know exactly anymore how it works I assume it's this function call that does it:

ShortcutHelper.updateShortcuts(this, DBHelper.getLoyaltyCard(mDatabase, loyaltyCardId));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android: 5 common: occasional Affects or can be seen by some users regularly or most users rarely severity: major Severely degrades major functionality or product features, with no satisfactory workaround state: help wanted I looked into this issue but couldn't solve it quickly type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants