Make type equivalence check for string and ostream more robust #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamoll
force-pushed
the
pr-more-robust-equivalence-check
branch
from
ebcf0d1
to
b81a7c7
Compare
iMichka
force-pushed
the
pr-more-robust-equivalence-check
branch
from
b81a7c7
to
bd4a882
Compare
iMichka
changed the title
|
Thanks. I know this part of the code is hard to debug. Nothin I'll change anytime soon. I'm not investing much time in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS 11.3 / Xcode 12.5 with castxml 0.4.3 installed via MacPorts, some uses of std::string were not correctly identified (the decl_string was
::std::basic_string<char,std::char_traits<char>,std::allocator<char>>, without any spaces, which didn't match anything). This causeddecl_wrappers.python_traits.is_immutableto return the wrong thing, which in turn causeddecl_wrappers.python_traits.call_traitsto generate broken code. This was a pain to track down. The responsible code seemed rather brittle. This is a simple attempt to make it slightly more robust.