Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviews are associated with a submission, and can be either approved or rejected #8

Open
ryangchung opened this issue Jun 10, 2024 · 0 comments · May be fixed by #24
Open

Reviews are associated with a submission, and can be either approved or rejected #8

ryangchung opened this issue Jun 10, 2024 · 0 comments · May be fixed by #24
Assignees
@MrRibcage
Labels
enhancement New feature or request

Comments

@ryangchung
Copy link

The reviews-service should be able to query and check whether a submission has been already been approved or rejected (see TODO comment in app/challenges-platform/services/reviews-service.ts).

AC:

  • Implement check for approved or rejected
  • Add jest test to check approved and rejected (can refer to test/challenges-platform/services/submissions-service.test.ts)
@MrRibcage MrRibcage self-assigned this Jun 12, 2024
@ryangchung ryangchung added the enhancement New feature or request label Jun 17, 2024
@MrRibcage MrRibcage linked a pull request Jun 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrRibcage MrRibcage

Labels
enhancement New feature or request
Projects
Summer 2024 Open Source Contributions
Status: For Review - Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Submission status check CarletonComputerScienceSociety/submissions-platform
2 participants
@MrRibcage @ryangchung