Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive class method Entity.isInWaterRainOrBubble() calls impacting tick rate #1

Open
Paulie820 opened this issue Aug 25, 2024 · 0 comments

Comments

@Paulie820
Copy link

Describe the bug
With Buildify installed, calls to the class method Entity.isInWaterRainOrBubble() are made. The calls can grow to be excessive impacting server performance and causing high mspt. See the attached spark log.

https://spark.lucko.me/a2z2m0AFdh

The same server was run with Buildify (and it's dependent in Caliber Mod) removed, seeing an immediate improvement from the lack of Entity.isInWaterRainOrBubble() calls. See the attached spark log

https://spark.lucko.me/tZrQtlZkWs

To Reproduce
Steps to reproduce the behavior:

  1. Install Buildify
  2. Run game world
  3. With just the Caliber set installed, this does not cause major performance issues, even when lightly modding. On larger packs is where the issue becomes apparent.

Expected behavior
Normal TPS

Additional context
This may be also related to world height. I used this mod in a roughly 300 mod pack with no issues on a world with an 800 block world height. When I switched to a world with a 1500 block height and that same set of mods, the tick rate issue began.

Testing with the same world height and a reduced modpack size, there are no tick rate issues. If any specific information is needed, please let me know as I would love to reintegrate caliber back into the pack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant