remove diacritics on first letter on grouped contact #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
To remove diacritics, you can normalize in NFKD, strip out non-ascii chars, then eventually re-normalize in NFC… Don't know if it's worth the hassle, anyway, it may avoid the dependency.
See : https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Objets_globaux/String/normalize
and https://fr.wikipedia.org/wiki/Normalisation_Unicode#NFKD
MonsieurLanza
approved these changes
May 29, 2019
iamdey
force-pushed
the
fix/frontend/contactbook_diacritics
branch
from
ed9f36d
to
a2d197a
Compare
MonsieurLanza
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1398