-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move our Mixin configuration system for each mod into a common module #2
Comments
Depends on #3. |
Hey! I've worked on this and extracted (and modified to work as an external library) the config system in the last few days, and pushed the code to https://github.com/altrisi/CaffeineConfig. A summary of what I've changed (other than the obvious of not being tied to any specific mod):
I also have branches of Lithium and Sodium moved to use the library that I'll probably open as draft PRs later. All that's missing is anything you'd like me to change, and then I can transfer the repo I think, and you should be able to publish it into maven and start using it (I tested both Sodium and Lithium via mavenLocal, I have NOT prepared the build to get published to a maven, since I don't know how to do that). For anything feel free to reply here or @ me on discord, same name. Or close the PRs if you don't want them, also ok. Edit: Also it doesn't have an icon since I'm unable to make those things, neither the name is very original. |
Just some more ideas (not sure whether they would be used): Allow / Force a description string when defining an option. These ideas are partially inspired by carpet mod |
@altrisi Hey, sorry for the tremendously late response. I'm super thankful for your work here and it looks like a great launch pad. In the next few days I'll be able to more extensively review things here, and we can discuss potentially incorporating your work into a new repository. 🙂 (if you're happy with it) |
@2No2Name I think as far as improvements go, we should focus on getting a new repository / maven artifacts set up prior to making any more changes, so we can move this code out of each of our mods. It seems Altrisi has covered all that important work in their repository already (i.e. JiJ and some generalization.) |
Right now, our mods (Sodium, Lithium, and Phosphor) all implement more or less the same system for managing Mixin configurations. Most of the work on this gets done in Lithium and is then manually copied into the other projects. This tends to be error prone and means our implementations are subtly different between each.
An example of this Mixin plugin in Lithium can be found here, and the configuration system can be found here.
Moving this code into a Maven project that each one of our mods can instead pull in would be a big win for hygiene. We've also seen community interest here and there for a public library, so fixing this also opens that door up.
The text was updated successfully, but these errors were encountered: