Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating Class to Nested Fully Qualified Class #4

Open
gabizou opened this issue Nov 23, 2019 · 1 comment
Open

Migrating Class to Nested Fully Qualified Class #4

gabizou opened this issue Nov 23, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@gabizou
Copy link

gabizou commented Nov 23, 2019

In the commit for SpongeCommon, there's a migration of ImmutableValue -> Value.Immutable, but it appears that instead of importing the outer class, it will fully qualify the class in usage, resulting in long lines.

@jamierocks jamierocks added the bug Something isn't working label Nov 23, 2019
@jamierocks
Copy link
Member

It seems likely that this is due to inner classes having the wrong inner class notation.

Our tools can't disern between com.Outer.Inner and com.Outer$Inner essentially, so input data must use the $ delimeter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants