Develop prepare new main version

CODING_GUIDELINES_FRONTEND.md

@@ -0,0 +1,16 @@
+
+# Code Guidelines
+
+
+## General
+- Close your tag - Leaving some tags open is simply a bad practice. Only self-closing tags are valid. Normal elements can never have self-closing tags.
+- Don't use inline styles(if possible) - When creating your markup, do not use inline styling because it would be very hard to override these styles in case you need to.
+- Try not to use "!important" - Using the !important declaration is often considered bad practice because it has side effects that mess with one of CSS's core mechanisms: specificity. In many cases, using it could indicate poor CSS architecture.
+
+## Components
+- Organize files and components in a folder structure like this. This makes it easy to find the code related to a page, without having to browse the entire file explorer. Try, as much as possible, to respect the SOLID principles. Mainly by creating autonomous and extensible components: inject the smallest possible service or parameter, manage all the possibilities offered by the component. For example, a data modification page should display the data, check their values and save the data at the end of the process.
+
+## UI
+# Responsiveness
+- Use the bootstrap grid and it's column classes to have easy and responsive design. [Bootstrap](https://getbootstrap.com/docs/5.3/layout/columns/)
+- Decide if you want to develop mobile or desktop design first and test respectively.

documentation/developer-docs/importer/FWO-import-api.md

@@ -140,7 +140,8 @@ here we describe a single rule:
     "rule_head_text": null,                                 // string: for section headers this is the field to use
     "rule_from_zone": null,                                 // string: source zone (if applicable) of the rule
     "rule_to_zone": null,                                   // string: destination zone (if applicable) of the rule
-    "rule_type": "access"                                   // string: type of the nat rule: "access|combined|original|xlate", default "access"
+    "rule_type": "access",                                  // string: type of the nat rule: "access|combined|original|xlate", default "access"
+    "rule_custom_fields": "{\"field1\": \"value1\"}"        // string: json serialized user defined fields
 }
 ```
 - rule_track can be any of log, none, alert, userdefined, mail, account, userdefined 1, userdefined 2, userdefined 3, snmptrap, log count, count, log alert, log alert count, log alert count alarm, log count alarm, count alarm, all, all start, utm, utm start, network log

documentation/installer/install-advanced.md

@@ -1,6 +1,6 @@
 # Advanced installation options
 
-always change into the firewwall-orchestrator directory before starting the installation!
+always change into the firewwall-orchestrator directory before starting the installation.
 
 ## Install parameters
 
@@ -38,7 +38,7 @@ ansible-playbook site.yml -K
 ### Installation behind a proxy (no direct Internet connection)
 
 By default, during installation or upgrade the proxy settings are read from the OS environment of the installer host.
-For example you may have a global system-wide config file /etc/profile.d/proxy.sh with the following content:
+For example you may either use /etc/environment or add a global system-wide config file /etc/profile.d/proxy.sh and add the following content:
 
 ```console
 export http_proxy=http://proxy.int:3128
@@ -49,7 +49,7 @@ export no_proxy=127.0.0.1,localhost
 Also make sure that your proxy is configured in your .gitconfig to be able to do the initial repo cloning.
 See https://gist.github.com/evantoli/f8c23a37eb3558ab8765.
 
-If instead you need to individually set a proxy before installation/upgrade, use the following comamnds in your terminal:
+If instead you need to individually set a proxy before installation/upgrade, use the following commands in your terminal:
 ```console
 export http_proxy=http://proxy.int:3128
 export https_proxy=http://proxy.int:3128
@@ -88,6 +88,8 @@ NB: for vscode-debugging, you also need access to
     visualstudio.com
 
 
+#### Pyhton proxy config
+
 Remember if your server resides behind a proxy that you will have to set the proxy for pip as follows before installing ansible:
 
          pip config set global.proxy http://proxy:3128
@@ -97,6 +99,16 @@ In case of timeout issues (you might be behind a security proxy that does intens
 
           pip --default-timeout=3600 install ansible
 
+##### issues with existing pip config
+
+In case of errors with existing pip config, do not use the script to create the venv but proceed as follows:
+
+remove any local pip config and install manually:
+
+    rm -f $HOME/.config/pip/pip.conf
+    python3 -m venv ansible-venv
+    source ansible-venv/bin/activate
+    pip install ansible
 
 ### Parameter "api_no_metadata" to prevent meta data import
 

documentation/installer/install-for-testing.md

@@ -12,7 +12,7 @@ This includes:
 Note: the relevant secrets are displayed at the very end of the installation. They can also be found in the etc/secrets directory.
 
 ```console
-ansible-playbook/ site.yml -e "testkeys=yes" -K
+ansible-playbook site.yml -e "testkeys=yes" -K
 ```
 
 A static jwt key helps with debugging c# code in visual studio (code) - you can use a static backend (ldap & api) with these keys.

documentation/revision-history-develop.md

@@ -217,3 +217,11 @@ bugfix release:
 # 8.2.4 - 19.06.2024 DEVELOP
 - owner-filtering for new report type
 - new setting for email recipients
+
+# 8.3.1 - 08.07.2024 DEVELOP
+- workflow: external state handling
+- fix config value
+- remove uniqueness of owner names
+
+# 8.3.2 - 09.09.2024 DEVELOP
+- Added welcome message and settings

inventory/group_vars/all.yml

@@ -1,5 +1,5 @@
 ### general settings
-product_version: "8.3.1"
+product_version: "8.3.2"
 ansible_user: "{{ lookup('env', 'USER') }}"
 ansible_become_method: sudo
 ansible_python_interpreter: /usr/bin/python3

inventory/group_vars/apiserver.yml

@@ -8,7 +8,7 @@ api_hasura_admin_test_password: "not4production"
 api_user_email: "{{ api_user }}@{{ api_network_listening_ip_address }}"
 api_home: "{{ fworch_home }}/api"
 api_hasura_cli_bin: "{{ fworch_home }}/api/bin/hasura"
-api_hasura_version: "v2.40.0"
+api_hasura_version: "v2.41.0"
 api_project_name: api
 api_no_metadata: false
 api_rollback_is_running: false

inventory/group_vars/sampleserver.yml

@@ -7,7 +7,7 @@ sample_fortigate_basename: fortigate
 sample_fortigate_name: "{{ sample_fortigate_basename }}_demo"
 sample_checkpoint_basename: "checkpoint"
 sample_checkpoint_name: "{{ sample_checkpoint_basename }}_demo"
-sample_checkpoint_uri: "https://fwodemodata.cactus.de/demo04_cpr8x.json"
+sample_checkpoint_uri: "https://fwodemodata.cactus.de/demo11-r82.json"
 demo_cpr8x_name_without_demo: "CPR81"
 demo_cpr8x_name: "{{ demo_cpr8x_name_without_demo}}_demo"
 demo_cpr8x_uri: "https://fwodemodata.cactus.de/demo09_cpr81.json"

inventory/hosts.yml

@@ -1,20 +1,20 @@
+# If you want to use distributed installation, follow the steps on localhost
 # 1. ssh-keygen -t rsa
 # Press enter for each line 
 # 2. cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys
 # 3. chmod og-wx ~/.ssh/authorized_keys
-# 4. change ansible_connection to ssh and ansible_host to your host
+# 4. ssh-copy-id <user>@<remote-server>
+# 5. add remote servers below
 
 all:
   hosts:
     localhost:
       ip_address: 127.0.0.1
       ansible_connection: local
-      # ansible_connection: local
-      # ansible_host: localhost
 #   Add servers for distributed installation here. Use these servers in the children dictionary below.
 #    ui-srv:
 #      ansible_connection: ssh
-#      ansible_host: 192.168.121.2
+#      ansible_host: 192.168.2.3
   children:
 
     frontends:

roles/FWO.sln

@@ -35,11 +35,11 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "FWO.Recert", "lib\files\FWO
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "files", "files", "{B48F8BD5-1056-4670-BEFA-F4A260293B6F}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "FWO.Encryption", "lib\files\FWO.Encryption\FWO.Encryption.csproj", "{6EBEBF57-3399-4008-BA10-0D21F6827244}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "FWO.Encryption", "lib\files\FWO.Encryption\FWO.Encryption.csproj", "{6EBEBF57-3399-4008-BA10-0D21F6827244}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "FWO.GlobalConstants", "lib\files\FWO.GlobalConstants\FWO.GlobalConstants.csproj", "{0CBD4CC5-3E39-4134-A0E1-4DB8999619F3}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "FWO.GlobalConstants", "lib\files\FWO.GlobalConstants\FWO.GlobalConstants.csproj", "{0CBD4CC5-3E39-4134-A0E1-4DB8999619F3}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "FWO.Tufin.SecureChange", "lib\files\FWO.Tufin.SecureChange\FWO.Tufin.SecureChange.csproj", "{17AA0E0C-BB46-42FE-A08C-68539EA7FD53}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "FWO.Tufin.SecureChange", "lib\files\FWO.Tufin.SecureChange\FWO.Tufin.SecureChange.csproj", "{17AA0E0C-BB46-42FE-A08C-68539EA7FD53}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -103,10 +103,6 @@ Global
 		{520779B1-20EB-45D9-8A02-D0C4DFEC9302}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{520779B1-20EB-45D9-8A02-D0C4DFEC9302}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{520779B1-20EB-45D9-8A02-D0C4DFEC9302}.Release|Any CPU.Build.0 = Release|Any CPU
-		{14B56819-F629-4CE9-BBC0-7579392EFC83}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{14B56819-F629-4CE9-BBC0-7579392EFC83}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{14B56819-F629-4CE9-BBC0-7579392EFC83}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{14B56819-F629-4CE9-BBC0-7579392EFC83}.Release|Any CPU.Build.0 = Release|Any CPU
 		{6EBEBF57-3399-4008-BA10-0D21F6827244}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{6EBEBF57-3399-4008-BA10-0D21F6827244}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{6EBEBF57-3399-4008-BA10-0D21F6827244}.Release|Any CPU.ActiveCfg = Release|Any CPU