Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib pdf generation - replace deprecatd wkhtml with alternative solution #2322

Open
10 of 12 tasks
tpurschke opened this issue Jan 25, 2024 · 2 comments
Open
10 of 12 tasks

lib pdf generation - replace deprecatd wkhtml with alternative solution #2322

tpurschke opened this issue Jan 25, 2024 · 2 comments
Assignees
@tpurschke @SolidProgramming @NilsPur
Labels
dependencies Pull requests that update a dependency file external Depends on an external project
Milestone
next consolidatio...

Comments

@tpurschke
Copy link
Contributor

tpurschke commented Jan 25, 2024 •
edited by SolidProgramming
Loading

wkhtml project has been archived end of 2023: https://wkhtmltopdf.org/status.html

possible replacements:

Testing: dotnet add package Microsoft.Playwright.NUnit

Current favorite: https://github.com/hardkoded/puppeteer-sharp.git

  • Replace wkhtml in all pages
  • Remove wkhtml from projects
  • Make paper format dropdowns work with puppeteer
  • The binaries should be downloaded in the unit tests
  • The binaries should be downloaded on first start up
@tpurschke tpurschke added the external Depends on an external project label Jan 25, 2024
@tpurschke tpurschke added this to the next consolidation issues milestone Jan 25, 2024
@tpurschke tpurschke added the dependencies Pull requests that update a dependency file label Jan 26, 2024
@tpurschke tpurschke changed the title lib pdf generation - replace wkhtml with WeasyPrint lib pdf generation - replace wkhtml with e.g. WeasyPrint Feb 1, 2024
@tpurschke tpurschke mentioned this issue Apr 26, 2024
Open
@tpurschke tpurschke changed the title lib pdf generation - replace wkhtml with e.g. WeasyPrint lib pdf generation - replace deprecatd wkhtml with alternative solution Apr 30, 2024
@SolidProgramming SolidProgramming self-assigned this Sep 3, 2024
@SolidProgramming
Copy link

SolidProgramming commented Sep 9, 2024 •
edited
Loading

Maybe this is worth testing...

Youtube.com | Nick Chapsas | The Free Way to Create Awesome PDFs

@SolidProgramming SolidProgramming added the in progress assignee is working on it label Sep 10, 2024
SolidProgramming added a commit to SolidProgramming/firewall-orchestrator that referenced this issue Sep 10, 2024
@SolidProgramming
[+] Added puppeteersharp for pdf creation CactuseSecurity#2322
f1126c6
SolidProgramming added a commit to SolidProgramming/firewall-orchestrator that referenced this issue Sep 13, 2024
@SolidProgramming
[-] Removed wkhtml
1c56417 
[~] Changed PDF Test to use puppeteer
CactuseSecurity#2322
@SolidProgramming SolidProgramming removed the in progress assignee is working on it label Sep 16, 2024
@SolidProgramming
Copy link

SolidProgramming commented Sep 16, 2024 •
edited
Loading

Reopened as the code in PR #2536 doesn't work for Ubuntu 24.04

Added new tasks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tpurschke tpurschke

@SolidProgramming SolidProgramming

@NilsPur NilsPur

Labels
dependencies Pull requests that update a dependency file external Depends on an external project
Projects
None yet
Milestone
next consolidation issues
Development

No branches or pull requests
3 participants
@tpurschke @SolidProgramming @NilsPur