Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree visualization for sparse trees #54

Open
souravchk25 opened this issue Feb 20, 2022 · 1 comment
Open

Fix tree visualization for sparse trees #54

souravchk25 opened this issue Feb 20, 2022 · 1 comment

Comments

@souravchk25
Copy link

souravchk25 commented Feb 20, 2022

The t(s,a,s_prime) matrix is assumed to be always dense regardless of the tree size, however, it is possible that a student initializes by assigning 0 to all triplets and then overwrite the ones which eventually gets hit.

This misstep creates the tree to be extremely sparse even if the tree is very small and visualizable.

visualize_tree() can disregard the 0 values provided.

@zsunberg
Copy link
Collaborator

Thanks, @souravchk25 , will fix this for next year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants