Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule editor: display talk notes as title #609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

terceiro
Copy link
Contributor

Displaying the talk title again in the title is pointless since the
title is already the main element displayed. Showing the notes makes it
easier for the people doing the scheduling to see e.g. notes about
scheduling restrictions etc.

Displaying the talk title again in the title is pointless since the
title is already the main element displayed. Showing the notes makes it
easier for the people doing the scheduling to see e.g. notes about
scheduling restrictions etc.
@hodgestar
Copy link
Member

@terceiro Thanks. If I understand what you're seeing, the title is displayed both in the draggable item and as the tooltip for that item? I agree that the notes are a much more sensible thing to display in the tooltip.

I'm a bit worried that the div.title attribute is used somewhere else though. E.g. the schedule JS has this line e.target.innerHTML = data.getAttribute('title'); which seems to suggest that the title of the draggable is also used to fill in some part of the schedule during editing?

@terceiro
Copy link
Contributor Author

yes, I think I overlooked this. I will send a better version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants