Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change catalogue items #3277

Merged
merged 17 commits into from
Apr 11, 2024
Merged

Change catalogue items #3277

merged 17 commits into from
Apr 11, 2024

Conversation

Macroz
Copy link
Collaborator

@Macroz Macroz commented Apr 5, 2024

Close #3271

bulk-update1 bulk-update2

Checklist for author

Remove items that aren't applicable, check items that are done.

Reviewability

  • Link to issue
  • Consider adding screenshots for ease of review

Backwards compatibility

  • API is backwards compatible or completely new

Documentation

  • Update changelog if necessary
  • API is documented and shows up in Swagger UI
  • Update manual/ (if applicable) (added to Check manual #3197)

Testing

  • Complex logic is unit tested
  • Valuable features are integration / browser / acceptance tested automatically

Macroz added 14 commits April 5, 2024 21:10
@Macroz
clean: remove unused imports
ffa7bc9
@Macroz
feat: bulk update of form and workflow
01a69ac
@Macroz
feat: test with improved API
debe9f0 
If no parameter is sent it means no change is desired. A nil means
there should be e.g. no form.
@Macroz
refactor: simplify using the table row subscription
38111c2 
This will also fix a bug where the on-select is not called because it
is not always in the table declaration if trying to call simply from
another file.
@Macroz
refactor: group, simplify and clarify update catalogue item
e63e8b9
@Macroz
feat: basic browser test update catalogue item
c2bf082
@Macroz
clean: remove organization creation
798e613 
Doesn't need to be created. Also conflicts with other tests.
@Macroz
feat: use waits because they are more robust
6c11fc4
@Macroz
chore: add more etaoin functions
8b28650
@Macroz
feat: allow slurping any selected trs
f324a84
@Macroz
feat: select option improvement
a1e8cfc 
If you try to re-select an option from a dropdown, it may not be
visible anymore thanks to React Select. So let's rather wait for
the input to just be enabled, then we can fill it again.

Also let's add the clear-option too.
@Macroz
feat: comprehensive browser tests for update catalogue item
bcbc0fd
@Macroz
doc: update CHANGELOG
6f4a05b
@Macroz
fix: cljfmt
9b205fd
aatkin
aatkin approved these changes Apr 8, 2024
View reviewed changes
resources/translations/sv.edn Outdated Show resolved Hide resolved
resources/translations/sv.edn Outdated Show resolved Hide resolved
src/cljs/rems/administration/catalogue_items.cljs Show resolved Hide resolved
src/cljs/rems/administration/update_catalogue_item.cljs Outdated Show resolved Hide resolved
test/clj/rems/api/test_catalogue_items.clj Show resolved Hide resolved
test/clj/rems/api/test_catalogue_items.clj Show resolved Hide resolved
src/cljs/rems/administration/catalogue_items.cljs Outdated Show resolved Hide resolved
@Macroz Macroz mentioned this pull request Apr 11, 2024
Open
@Macroz Macroz merged commit 8ed895a into master Apr 11, 2024
7 checks passed
@Macroz Macroz deleted the change-catalogue-items branch April 11, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatkin aatkin aatkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit multiple catalogue items at once
2 participants
@Macroz @aatkin