-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo in vspec v3.0 makes vss-tools 4.x fail #734
Comments
We had a discussion around a year ago to clarify that VSS names are case sensitive, see #569 and as part of that we changed documentation and vss-tools. So far we have not had any ambition to keep support for older VSS versions in VSS-tools, the assumption has sort of been that you use the VSS-tools version related to the VSS-version you are using. This issue is a good starting point to discuss if we better should change this approach; some alternatives below
However, supporting older and newer versions in parallel comes at a cost as maintenance and refactoring becomes more complex. |
I would not have strong objections to requiring alignment between catalog version and tool version. The main advantages of this would be to reduce testing and simplicity of use. Otherwise, we could support some form of backwards compatibility, where the latest version of the tools would support older versions of the catalog. This seems onerous and may not be possible in the long term. With a backwards compatible approach or an approach where one specifies the syntax version, could this instead be done by looking at the existing version entries in the catalog (i.e., Vehicle.VersionVSS)? |
I found something really interesting in vspec 3.0 there is a typo
Actuator
instead ofactuator
https://github.com/COVESA/vehicle_signal_specification/blob/525e2bd00ddf061851bdc75e849178e5d3ad5833/spec/Powertrain/Battery.vspec#L229C9-L229C17
and this makes load_tree impossible for vspec definiton 3.0
Suggested fix would be to allow upper and lower case here
https://github.com/COVESA/vss-tools/blob/839b0d087ecb6419372476fb99a7d8c160c7d13b/vspec/model/constants.py#L284C29-L284C30
The text was updated successfully, but these errors were encountered: