Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor src/notifications.js to reduce cognitive complexity from 16 to 15 #578

Open
wants to merge 1 commit into
base: f24
Choose a base branch
from

Conversation

ay0503
Copy link

@ay0503 ay0503 commented Sep 6, 2024

Reduced the cognitive complexity of notification.js by reducing the nesting level within the ForEach callback of the notifications list. As a result, the code is a bit more modular and easier to read through the division of multiple helpers.

Copy link

sonarcloud bot commented Sep 6, 2024

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10730576039

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.671%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/notifications.js 7 8 87.5%
Totals Coverage Status
Change from base Build 10607818019: 0.0%
Covered Lines: 22324
Relevant Lines: 25583

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants