Refactored code in public/src/client/account/settings.js to reduce complexity. #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10730309223Details
💛 - Coveralls |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
saveSettings()function in settings.js, reducing cognitive complexity from 17 to 15 to improve readability and for simplicity. This was done by making multiple helper functionshandleNewSettings(),processNewSettings(), andcheckAndUpdateConfig().This PR resolves #570, with the sonar cloud warning: https://sonarcloud.io/project/issues?open=AZFmi_ySybYwxy-_uEQC&id=CMU-313_NodeBB
This refactored code is covered by the test file: ./test/public/src/settings.js
UI Test Instructions