Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create PR here from my gitflow-avh fork #7

Closed
bmcdonnell opened this issue Jun 13, 2023 · 3 comments
Closed

Cannot create PR here from my gitflow-avh fork #7

bmcdonnell opened this issue Jun 13, 2023 · 3 comments

Comments

@bmcdonnell
Copy link
Contributor

Summary: Please find an easy way to allow easy submission/migration of PRs from petervanderdoes/gitflow-avh to your repo.

I saw your request:

I'm in the process of updating gitflow. If you could kindly resubmit your pull request against my fork here as it appears this fork is no longer being updated.

And I see that you made the same request on other open PRs there.

However, I can't create a PR on this repo from my gitflow-avh fork.

image

I could create a PR on your other repo (CJ-Systems/gitflow-avh, which was forked from petervanderdoes/gitflow-avh), but I had to manually edit the URL to start it. (GitHub was trying to make me do the PR from my branch on its upstream (petervanderdoes/gitflow-avh), and would not allow even your gitflow-avh fork in the pull-down menu (let alone your gitflow-cjs).)

image

When I try to do the same manual URL modification to create the PR on this repo (gitflow-cjs), it doesn't even let me.

image

If you want people to migrate their PRs from petervanderdoes/gitflow-avh to here, you'll probably get the most compliance if you make it as easy as possible for them to do so. I think you'll need to start by making your target repo a proper fork of petervanderdoes/gitflow-avh. Then it seems you may need to also provide instructions on how to create the PRs (which may include manually tweaking the URL, since GitHub doesn't seem to make it possible to submit a PR to a peer repo using the webUI).

@ChrisJStone
Copy link
Member

Thank you for bringing this to my attention. I'll look into this and get it resolved and let you know.

@ChrisJStone
Copy link
Member

gitflow-cjs is now setup as a direct fork of gitflow-avh. I was able to select my fork from the base repository drop down menu when I selected new pull request from your fork

image

Since my fork of gitflow is not your upstream you would need to do this every time you wanted to submit a PR from the webUI.

There's a ongoing discussion Change default base repository for pull requests on forks That deals with a similar situation. In short right now the only way to change the default base repository for PR's would be to create a new fork if using the webUI for PR's.

@bmcdonnell
Copy link
Contributor Author

That worked, and I was even able to do it with the webUI. (No manual URL editing.)

@ChrisJStone ChrisJStone transferred this issue from CJ-Systems/gitflow-cjs-backup Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants