From bb53aae336a133d2b1b29b5f1d211a785d002f44 Mon Sep 17 00:00:00 2001 From: Martin Pulec Date: Wed, 26 Jul 2023 17:26:07 +0200 Subject: [PATCH] silence audio filter: fixed build strdupa compat not included but not needed, VLA can be used --- src/audio/filter/silence.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/audio/filter/silence.c b/src/audio/filter/silence.c index 691bf4c08..cd7c5ca72 100644 --- a/src/audio/filter/silence.c +++ b/src/audio/filter/silence.c @@ -79,14 +79,17 @@ init(struct module *parent, const char *cfg, void **state) } struct state_silence *s = calloc(1, sizeof *s); - char *fmt = strdupa(cfg); + const size_t len = strlen(cfg) + 1; + char fmt[len]; + strncpy(fmt, cfg, len); + char *tmp = fmt; char *item = NULL; char *end_ptr = NULL; - while ((item = strtok_r(fmt, ",", &end_ptr)) != NULL) { + while ((item = strtok_r(tmp, ",", &end_ptr)) != NULL) { assert(s->silence_channels_count < MAX_CHANNELS - 1); s->silence_channels[s->silence_channels_count++] = strtol(item, NULL, 10); - fmt = NULL; + tmp = NULL; } *state = s; return AF_OK;