Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More GetStringInput size optimizations #474

Merged
merged 11 commits into from
Feb 8, 2024
Merged

More GetStringInput size optimizations #474

merged 11 commits into from
Feb 8, 2024

Conversation

calc84maniac
Copy link
Contributor

Builds off of the previous PR to implement more size optimizations (including some JP to JR conversions due to the reduced size, which is why I'm making a PR to verify the build)

@mateoconlechuga
Copy link
Member

@calc84maniac is this good to be merged?

@calc84maniac
Copy link
Contributor Author

Yes, as far as I know, but it should be squashed I think

@mateoconlechuga mateoconlechuga merged commit 30cfdf2 into master Feb 8, 2024
7 checks passed
@mateoconlechuga mateoconlechuga deleted the getstringinput-sizeopts branch February 8, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calc84maniac @mateoconlechuga