Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues found when analyzed the project's dart code #185

Open
manoj1749 opened this issue Mar 4, 2023 · 7 comments
Open

Issues found when analyzed the project's dart code #185

manoj1749 opened this issue Mar 4, 2023 · 7 comments

Comments

@manoj1749
Copy link

  • 10 issues found when we analyze the project's dart code using flutter analyze
  • Basically flutter analyze, Analyzes the project's Dart code.

Issues Found

info • 'toggleableActiveColor' is deprecated and shouldn't be used. No longer used by the framework,
          please remove any reference to it. For more information, consult the migration guide at
          https://flutter.dev/docs/release/breaking-changes/toggleable-active-color#migration-guide.
          This feature was deprecated after v3.4.0-19.0.pre • lib/theme/app_theme.dart:13:5 •
          deprecated_member_use
   info • 'toggleableActiveColor' is deprecated and shouldn't be used. No longer used by the framework,
          please remove any reference to it. For more information, consult the migration guide at
          https://flutter.dev/docs/release/breaking-changes/toggleable-active-color#migration-guide.
          This feature was deprecated after v3.4.0-19.0.pre • lib/theme/app_theme.dart:26:5 •
          deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 • lib/ui/views/login/login_view.dart:159:31 • deprecated_member_use
   info • 'subtitle1' is deprecated and shouldn't be used. Use titleMedium instead. This feature was
          deprecated after v3.1.0-0.0.pre • lib/ui/widgets/dumb_widgets/document_type_card.dart:20:49 •
          deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 • lib/ui/widgets/dumb_widgets/password_change_dialog_widget.dart:49:27
          • deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 • lib/ui/widgets/dumb_widgets/torrent_label_dialog.dart:77:11 •
          deprecated_member_use
  error • The method 'FlatButton' isn't defined for the type '_FloatingBoxBottomSheet' •
         lib/ui/widgets/smart_widgets/bottom_sheets/bottom_sheet_setup.dart:88:19 • undefined_method
  error • The method 'FlatButton' isn't defined for the type 'ConfirmBottomSheetView' •
         lib/ui/widgets/smart_widgets/bottom_sheets/confirm_bottom_sheet/confirm_bottom_sheet_view.dart:
         53:15 • undefined_method
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 •
          lib/ui/widgets/smart_widgets/url_bottom_sheet/url_bottomsheet_view.dart:77:19 •
          deprecated_member_use
   info • 'primary' is deprecated and shouldn't be used. Use backgroundColor instead. This feature was
          deprecated after v3.1.0 •
          lib/ui/widgets/smart_widgets/url_bottom_sheet/url_bottomsheet_view.dart:110:25 •
          deprecated_member_use

10 issues found. (ran in 2.2s)
@vijaykarthiktk
Copy link

  • Remove references to the deprecated member toggleableActiveColor and use the recommended replacement as per the migration guide.

  • Replace references to the deprecated member primary with backgroundColor.

  • Replace references to the deprecated member subtitle1 with titleMedium.

  • Import the FlatButton method in the relevant files.

@manoj1749
Copy link
Author

  • Remove references to the deprecated member toggleableActiveColor and use the recommended replacement as per the migration guide.

  • Replace references to the deprecated member primary with backgroundColor.

  • Replace references to the deprecated member subtitle1 with titleMedium.

  • Import the FlatButton method in the relevant files.

I had resolved those issues and also made a pr to the develop branch, btw thanks for your suggestions

@virajbhartiya
Copy link

I have already solved this issue in PR #188

@manoj1749
Copy link
Author

I have already solved this issue in PR #188

@virajbhartiya A pr is already made resolving this issue, and if you had gone through the conversations in this issue you could have seen the open pr's which have been referenced to this issue.

@Detective-Khalifah
Copy link

About time the issue is closed

@Detective-Khalifah
Copy link

What Flutter SDK version did you guys use to build & run the project?

@dinpran
Copy link

dinpran commented May 21, 2023

Replace primary with background
In flat button I think you used that somehere else and did not provide all the required things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants