Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add consensus peaks subworkflow #37

Merged
merged 53 commits into from
Nov 29, 2023
Merged

feat: add consensus peaks subworkflow #37

merged 53 commits into from
Nov 29, 2023

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Nov 22, 2023

Changes

  • new module custom/consensuspeaks adopts the consensus peaks script from ASPEN.
  • new subworklfow consensus_peaks is a refactor of the consensus peaks script:
    • supports optional normalization
  • new modules for the consensus_peaks subworkflow:
    • cat
    • bedops/bedmap
    • bedtools: sort, merge, map
    • custom/combinepeakcounts
    • custom/normalizepeaks

dev notes

nf-core subworkflows create-test-yml fails locally, it assumes nf-core even in a custom repo (nf-core modules create-test-yml doesn't have this bug). Solution is to first commit & push the new subworkflow, then run it with the git remote specified, e.g.

PROFILE=docker nf-core subworkflows --git-remote https://github.com/CCBR/nf-modules  --branch consensus-peaks create-test-yml consensus_peaks --run-tests --force --no-prompts

Issues

Towards CCBR/CHAMPAGNE#151

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool kelly-sovacool marked this pull request as ready for review November 29, 2023 19:56
@kelly-sovacool kelly-sovacool self-assigned this Nov 29, 2023
@kelly-sovacool kelly-sovacool changed the title feat: add consensus peaks process feat: add consensus peaks subworkflow Nov 29, 2023
@kelly-sovacool kelly-sovacool merged commit 0dd8b5e into main Nov 29, 2023
25 of 27 checks passed
@kelly-sovacool kelly-sovacool deleted the consensus-peaks branch November 29, 2023 20:42
@kelly-sovacool kelly-sovacool added this to the 2023w48_1201 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant