Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared helper functions from ccbr_tools #105

Merged
merged 11 commits into from
Aug 15, 2024
Merged

Use shared helper functions from ccbr_tools #105

merged 11 commits into from
Aug 15, 2024

Conversation

kelly-sovacool
Copy link
Member

Changes

Refactor to use shared functions from https://github.com/CCBR/Tools

Issues

Related to CCBR/Tools#5

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Update docs if there are any API changes.
  • [ ] Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool
Copy link
Member Author

@samarth8392 could you test this on biowulf with a real dataset?

@kelly-sovacool kelly-sovacool marked this pull request as ready for review August 13, 2024 21:15
@kelly-sovacool kelly-sovacool changed the title Use shared helper function from ccbr_tools Use shared helper functions from ccbr_tools Aug 13, 2024
@samarth8392
Copy link
Collaborator

Update: run completed successfully using GUI. Testing the same run now with CLI.

@samarth8392
Copy link
Collaborator

CLI test completed successfully.

@samarth8392 samarth8392 merged commit 06debe7 into main Aug 15, 2024
3 checks passed
@samarth8392 samarth8392 deleted the use-tools branch August 15, 2024 13:21
@kelly-sovacool kelly-sovacool mentioned this pull request Aug 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants