Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in get_contact_sites endpoint #490

Open
ceesem opened this issue Mar 20, 2024 · 3 comments
Open

error in get_contact_sites endpoint #490

ceesem opened this issue Mar 20, 2024 · 3 comments

Comments

@ceesem
Copy link
Collaborator

ceesem commented Mar 20, 2024

Using the get_contact_sites endpoint throws a 500 error due to the keyword argument connected_edges in ChunkedGraph.get_subgraph_edges that is no longer used. You can find the contact sites line here and the subgraph function definition here. It doesn't look like the same functionality is still enabled, possibly due to the differences with how edges are stores in v2 and beyond. We should either fix this or remove the endpoint.

An example and the traceback is described on CAVEconnectome/CAVEclient#166 .

@bpdanskin
Copy link

bump

@akhileshh
Copy link
Contributor

Looks like this code was last edited during my refactor from v1 to v2. Since no one said anything (until now), it has stayed that way.

What is the expected behavior of get_contact_sites?

Would simply removing the keyword arg connected_edges fix the issue?

@akhileshh
Copy link
Contributor

Oh, it won't. There are some other remnants like _retrieve_connectivity that don't exist in v2.

I have asked @sdorkenw to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants