Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booleans in patch and science_configurations in config.yaml #306

Conversation

ccarouge
Copy link
Collaborator

@ccarouge ccarouge commented Aug 14, 2024

Add explanations in the documentation about specifying namelist options with boolean values in config.yaml since they need to be supplied with Python syntax and not Fortran syntax.

@ccarouge ccarouge changed the title (#305) - Booleans in patch and science_configurations in config.yaml Booleans in patch and science_configurations in config.yaml Aug 14, 2024
@ccarouge ccarouge force-pushed the 305-Explain-how-to-specify-logical-namelist-options-in-the-configyaml-file branch from af02301 to f599120 Compare August 14, 2024 01:43
@ccarouge ccarouge requested review from a team and bschroeter and removed request for a team August 14, 2024 01:47
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.21%. Comparing base (1dcd270) to head (f599120).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   70.21%   70.21%           
=======================================
  Files          20       20           
  Lines        1128     1128           
=======================================
  Hits          792      792           
  Misses        336      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bschroeter bschroeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Just a minor thing, what if the namelist writing routine were able to translate fortran syntax to Python at runtime? Would this head off future issues from users around syntax?

@ccarouge
Copy link
Collaborator Author

@bschroeter Yes that would be good if we could use Fortran syntax instead. The documentation path was the fastest path and important to do before we think of improvements.

@ccarouge ccarouge merged commit a44e986 into main Sep 10, 2024
4 checks passed
@ccarouge ccarouge deleted the 305-Explain-how-to-specify-logical-namelist-options-in-the-configyaml-file branch September 10, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants