Don't test jj_realistic_needs_to_be_more_clever on Windows
#1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This conditionally marks the `jj_realistic_needs_to_be_more_clever`
test as ignored, when the target is Windows. But the test is still
built on Windows, and can be run with:
cargo nextest run -p gix -- --ignored jj_realistic_needs_to_be_more_clever
This is a workaround for Byron#1575.
When run on Windows, the test previously checked if it was running
on CI and skipped its contents. This removes that logic, since the
test no longer runs by default on CI or otherwise.
EliahKagan
force-pushed
the
jj-realistic-ignore
branch
from
d2e483e
to
3adcfc5
Compare
Byron
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conditionally marks the
jj_realistic_needs_to_be_more_clevertest as ignored, when the target is Windows. But the test is still built on Windows, and can be run with:This is a workaround for #1575.
When run on Windows, the test previously checked if it was running on CI and skipped its contents. This removes that logic, since the test no longer runs by default on CI or otherwise.