Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize FeatureDefinitionAnalyzer #938

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

omsmith
Copy link
Contributor

@omsmith omsmith commented Nov 21, 2023

With ImmutabilityAnalyzer as reference (given run variability)

Analyzer Before After
ImmutabilityAnalyzer 12.200s 11.892s
FeatureDefinitionAnalyzer 1.598s 13ms

SpecialType.System_Int32,
SpecialType.System_Boolean,
SpecialType.System_String,
SpecialType.System_Single
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be a switch

j3parker
j3parker previously approved these changes Nov 21, 2023
@omsmith omsmith merged commit 6ff5f96 into main Nov 21, 2023
1 check passed
@omsmith omsmith deleted the omsmith/featuredefinition-opt branch November 21, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants