optimize InterfaceBinderAnalyzer #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omsmith
commented
Nov 20, 2023
Comment on lines
-26
to
+47
| var type = typeof( InterfaceBinder< /* InterfaceBinder_InterfacesOnly(ClassDto) */ ClassDto /**/ > ); | ||
| // This used to be considered an error; however, the updated version of the analyzer | ||
| // only looks at member accesses rather than generic type names to be less expensive | ||
| _ = typeof( InterfaceBinder<ClassDto> ); | ||
|
|
||
| _ = /* InterfaceBinder_InterfacesOnly(ClassDto) */ InterfaceBinder<ClassDto>.AllFields /**/; | ||
| _ = /* InterfaceBinder_InterfacesOnly(ClassDto) */ InterfaceBinder<ClassDto>.CreateAllFields() /**/; | ||
| _ = /* InterfaceBinder_InterfacesOnly(ClassDto) */ InterfaceBinder<ClassDto>.MatchedFields /**/; | ||
| _ = /* InterfaceBinder_InterfacesOnly(ClassDto) */ InterfaceBinder<ClassDto>.CreateMathedFields() /**/; |
There was a problem hiding this comment.
Erroring on a different usage (now just public API usage), but much less work to do so. I don't expect simply referencing the type InterfaceBinder<ClassDto> would really lead to any issues (outside of reflection, but that's a general hole regardless).
omsmith
commented
Nov 20, 2023
|
|
||
| public void TooManyGenericTypeArguments() { | ||
| var type = typeof( Action<int, int> ); | ||
| _ = /* InterfaceBinder_InterfacesOnly(Wacky) */ InterfaceBinder<Wacky>.AllFields /**/; |
There was a problem hiding this comment.
Wacky is TypeKind.ErrorType, so still works
JeffAshton
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ImmutabilityAnalyzer as reference (given run variability):