-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update CodeAnalysis packages #932
Conversation
@@ -20,6 +20,7 @@ | |||
<Nullable>enable</Nullable> | |||
<WarningsAsErrors>CA2016,Nullable</WarningsAsErrors> | |||
<TreatWarningsAsErrors>false</TreatWarningsAsErrors> | |||
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the request of the CodeAnalysis analyzers
@@ -24,7 +24,8 @@ public static class Diagnostics { | |||
category: "Correctness", | |||
defaultSeverity: DiagnosticSeverity.Error, | |||
isEnabledByDefault: true, | |||
description: "Tests need to be correctly categorized in order to be run." | |||
description: "Tests need to be correctly categorized in order to be run.", | |||
customTags: new[] { "CompilationEnd" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the request of the CodeAnalysis analyzers
923937b
to
df3b462
Compare
@@ -104,7 +104,7 @@ CancellationToken cancellationToken | |||
} | |||
|
|||
// ignore aliases that just import the class from the namespace | |||
string unqualifiedUsingName = usingDirective.Name.GetUnqualifiedNameAsString(); | |||
string? unqualifiedUsingName = usingDirective.Name?.GetUnqualifiedNameAsString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Name
became nullable
https://learn.microsoft.com/en-us/visualstudio/extensibility/roslyn-version-support?view=vs-2022