Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize IsExpressionTree #931

Merged
merged 1 commit into from
Nov 17, 2023
Merged

optimize IsExpressionTree #931

merged 1 commit into from
Nov 17, 2023

Conversation

omsmith
Copy link
Contributor

@omsmith omsmith commented Nov 17, 2023

ImmutabilityAnalyzer for reference

Before

D2L.CodeStyle.Analyzers.Immutability.ImmutabilityAnalyzer = 11.804 s
D2L.CodeStyle.Analyzers.Language.RequireNamedArgumentsAnalyzer = 9.463 s

##After

D2L.CodeStyle.Analyzers.Immutability.ImmutabilityAnalyzer = 14.822 s
D2L.CodeStyle.Analyzers.Language.RequireNamedArgumentsAnalyzer = 4.902 s

@omsmith omsmith merged commit a96c889 into main Nov 17, 2023
1 check passed
@omsmith omsmith deleted the omsmith/requiredargs-expression-optimization branch November 17, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffAshton JeffAshton JeffAshton approved these changes

@j3parker j3parker Awaiting requested review from j3parker j3parker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omsmith @JeffAshton