Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for conversion operators to the ConstantAttributeAnalyzer #915

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Adding support for conversion operators to the ConstantAttributeAnalyzer #915

merged 5 commits into from
Aug 18, 2023

Conversation

JeffAshton
Copy link
Contributor

No description provided.

@omsmith
Copy link
Contributor

omsmith commented Aug 18, 2023

Okay cool so this is adding support for say string to Constant<string>, but not the reverse, right?

@JeffAshton
Copy link
Contributor Author

Okay cool so this is adding support for say string to Constant<string>, but not the reverse, right?

Correct. I really want to avoid the other direction.

@JeffAshton JeffAshton merged commit 58ea689 into main Aug 18, 2023
1 check passed
@JeffAshton JeffAshton deleted the jashton/Constant-conversion-operators branch August 18, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omsmith omsmith omsmith approved these changes

@j3parker j3parker Awaiting requested review from j3parker j3parker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffAshton @omsmith