From 3396d62fef760d936f748b93caa75316c3c88749 Mon Sep 17 00:00:00 2001
From: Owen Smith <owen@omsmith.ca>
Date: Tue, 21 Nov 2023 15:40:21 -0500
Subject: [PATCH] switch

---
 .../LaunchDarkly/FeatureDefinitionAnalyzer.cs   | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/D2L.CodeStyle.Analyzers/ApiUsage/LaunchDarkly/FeatureDefinitionAnalyzer.cs b/src/D2L.CodeStyle.Analyzers/ApiUsage/LaunchDarkly/FeatureDefinitionAnalyzer.cs
index 299a8f85..5479354a 100644
--- a/src/D2L.CodeStyle.Analyzers/ApiUsage/LaunchDarkly/FeatureDefinitionAnalyzer.cs
+++ b/src/D2L.CodeStyle.Analyzers/ApiUsage/LaunchDarkly/FeatureDefinitionAnalyzer.cs
@@ -9,13 +9,6 @@ internal sealed class FeatureDefinitionAnalyzer : DiagnosticAnalyzer {
 
 		public const string FeatureDefinitionFullName = "D2L.LP.LaunchDarkly.FeatureDefinition`1";
 
-		private static readonly ImmutableHashSet<SpecialType> ValidTypes = ImmutableHashSet.Create(
-				SpecialType.System_Int32,
-				SpecialType.System_Boolean,
-				SpecialType.System_String,
-				SpecialType.System_Single
-			);
-
 		public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(
 				Diagnostics.InvalidLaunchDarklyFeatureDefinition
 			);
@@ -67,7 +60,7 @@ INamedTypeSymbol featureDefinitionType
 				return;
 			}
 
-			if( ValidTypes.Contains( namedValueType.SpecialType ) ) {
+			if( IsValidType( namedValueType ) ) {
 				return;
 			}
 
@@ -79,5 +72,13 @@ INamedTypeSymbol featureDefinitionType
 					messageArgs: new[] { namedValueType.ToDisplayString() }
 				);
 		}
+
+		private static bool IsValidType( INamedTypeSymbol valueType ) => valueType.SpecialType switch {
+			SpecialType.System_Int32 => true,
+			SpecialType.System_Boolean => true,
+			SpecialType.System_String => true,
+			SpecialType.System_Single => true,
+			_ => false
+		};
 	}
 }