-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect skeleton output of running Demo.py on geographical coordinates #27
Comments
What is the wrong output you're getting? Could you share them? I haven't worked on this project since ages, but iirc there is an issue with the numeric calculations for too small floating point numbers (intersections and such don't happen due to the computation errors inherent to floating point arithmetic and precision). |
@Botffy the test polygon I'm trying to generate a skeleton for is representing the nodes of a rectangular building footprint in latitude, longitude coorinates (coming from OpenStreetMap). Therefore the input polygon is in counterclockwise order and of the following format: 7.1489466,50.9653194 When running the demo script, the generated skeleton looks like this: The output (on DEBUG level) looks like the following: new line inn polygon: 7.1489765,50.9652408 new line inn polygon: 7.1491593,50.9652698 new line inn polygon: 7.1491291,50.9653486 DEBUG:name:Created LAV LAV 4378335216 Do I have to transform the polygon points from geographic coordinates (latitude, longitude) into another representation first in order to make the algorithm work properly? If so, what kind of coordinate system do I need to convert to? |
This converted one looks correct to me! It's a good roof. If you multiplied the input by a factor of ten or so, it would look less pixelated. I'm sorry I cannot be of more help at the moment. I've been planning to revisit this project since ages :$ |
I'm trying to run the demo script on some own testfiles in which the polygon is represented by geographical coordinates (float values with 7 decimal places). Do geographical coordinates in this format work for the algorithm or do I need to consider something special here? Thanks in advance!
The text was updated successfully, but these errors were encountered: