Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bolt12 support for submarine swaps #666

Merged
merged 2 commits into from
Oct 6, 2024
Merged

feat: bolt12 support for submarine swaps #666

merged 2 commits into from
Oct 6, 2024

Conversation

michael1011
Copy link
Member

@michael1011 michael1011 commented Sep 12, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Oct 6, 2024 11:48am
webapp-mainnet ✅ Ready (Inspect) Visit Preview Oct 6, 2024 11:48am

@michael1011 michael1011 mentioned this pull request Sep 25, 2024
Closed
@michael1011 michael1011 marked this pull request as ready for review September 25, 2024 05:26
maybeast
maybeast reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@maybeast maybeast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@kilrau
Copy link
Member

kilrau commented Oct 3, 2024

̶u̶t̶ACK:
Screencast from 2024-10-03 16-46-45.webm
Screencast from 2024-10-03 16-54-55.webm

@kilrau
Copy link
Member

kilrau commented Oct 3, 2024 •
edited
Loading

Not a must, but we can consider a basic loading animation in the "Create Atomic Swap" button for the bip353 fetch as it takes some seconds

@kilrau
Copy link
Member

kilrau commented Oct 3, 2024 •
edited by michael1011
Loading

And as just discussed we are not handling the "₿" prefix of BIP353 yet. That one is important.

kilrau
kilrau requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it always throws "invoice expiry too short" now. Using the same swap pair and Phoenix Testnet BIP353 and lno as before where it worked. I didn't manage to decode the final lni but don't think Phoenix changed the expiry.

Screencast.from.10-04-2024.06.11.19.PM.webm

@michael1011
Copy link
Member Author

Hmm it always throws "invoice expiry too short" now.

Your amount is > max 0-conf acceptance

@kilrau kilrau self-requested a review October 4, 2024 16:27
kilrau
kilrau requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but jeez why are they setting expiries so short...

Works. Mostly. The last full URI option Phoenix Testnet exposes for copying we don't handle yet:
image
image

@michael1011
Copy link
Member Author

michael1011 commented Oct 4, 2024 •
edited
Loading

Works. Mostly. The last full URI option Phoenix Testnet exposes for copying we don't handle yet:

We don't handle BIP-21s at all. Out of scope for this PR

@kilrau
Copy link
Member

kilrau commented Oct 4, 2024

We do. We don't populate the amount fields (#349 (review)) but we extract the addresses out of a BIP21

@kilrau
Copy link
Member

kilrau commented Oct 4, 2024

But yeah we can move this + populating amounts into a separate "BIP21" issue. I don't get why Phoenix exposes a BIP21 in the first place...

@kilrau kilrau mentioned this pull request Oct 4, 2024
Open
3 tasks
@kilrau kilrau self-requested a review October 4, 2024 18:44
@kilrau
Copy link
Member

kilrau commented Oct 6, 2024

Hmm today I am getting "failed to fetch". Phoenix is open and online. Not sure why it is not working today.
image

@kilrau kilrau mentioned this pull request Oct 6, 2024
Open
@michael1011 michael1011 merged commit 52f0c19 into main Oct 6, 2024
6 checks passed
@michael1011 michael1011 deleted the bolt12 branch October 6, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilrau kilrau kilrau approved these changes

@maybeast maybeast Awaiting requested review from maybeast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BIP-353 BOLT12 support
3 participants
@michael1011 @kilrau @maybeast