-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bolt12 support for submarine swaps #666
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Not a must, but we can consider a basic loading animation in the "Create Atomic Swap" button for the bip353 fetch as it takes some seconds |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm it always throws "invoice expiry too short" now. Using the same swap pair and Phoenix Testnet BIP353 and lno
as before where it worked. I didn't manage to decode the final lni
but don't think Phoenix changed the expiry.
Screencast.from.10-04-2024.06.11.19.PM.webm
Your amount is > max 0-conf acceptance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't handle BIP-21s at all. Out of scope for this PR |
We do. We don't populate the amount fields (#349 (review)) but we extract the addresses out of a BIP21 |
But yeah we can move this + populating amounts into a separate "BIP21" issue. I don't get why Phoenix exposes a BIP21 in the first place... |
Closes #669
Depends on BoltzExchange/boltz-backend#664