Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better model reporting #37

Open
Lash-L opened this issue Jan 13, 2023 · 0 comments
Open

Better model reporting #37

Lash-L opened this issue Jan 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Lash-L
Copy link
Collaborator

Lash-L commented Jan 13, 2023

Is your feature request related to a problem? Please describe.
We have issues with multiple types of toothbrushes being identified as the same toothbrush.

Describe the solution you'd like
There is a characteristic "a0f0ff02-5047-4d53-8208-4f72616c2d42" that is described as model here: https://github.com/wise86-android/OralBlue_python/blob/15e1a03bcb3350574d438e4593bcff59608a77a7/Protocol.md

Additional context
My toothbrush gives the following bytearray(b'2\x06k') which is similar, but different from the device_bytes in the manufacturer_id.

The problem is that we face the same problem with manufacturer_id - there is no way to know all of the modelids upfront. They don't correspond with the type_id on the bottom of the toothbrush(potentially another char does?)

The second problem is that we have no idea if the ones with the same device bytes from advertisement data would have the same model_id here.

Not sure if this is even worth looking at, as model does relatively little except for be a piece of text, and as long as we get io series or smart series, we are fine.

@Lash-L Lash-L added the enhancement New feature or request label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant