Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the custom error / rejection handling for routes in Delta #4754

Open
imsdu opened this issue Feb 23, 2024 · 0 comments
Open

Remove the custom error / rejection handling for routes in Delta #4754

imsdu opened this issue Feb 23, 2024 · 0 comments

Comments

@imsdu
Copy link
Contributor

imsdu commented Feb 23, 2024

Motivation
This was the case because back when we were using Monix BIO not all errors were exceptions.
Now that they all are we can rely on the ExceptionHandler and RejectionHandler provided by akka

Acceptance criteria

  1. There is no impact on error/rejection handling
  2. Code should be simplified

This section should be about results in domain terms, not implementation details.

Implementation notes

  • Every plugin will have to register its ExceptionHandler (it should be easy with Distage)
  • ResponseToJsonLd should only take care of the success path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant