Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4912 // Show validation error when updating resources #1536

Merged
merged 1 commit into from
May 14, 2024

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented May 14, 2024

Duplicate of PR #1532 but rebased on develop branch instead of merge-main.
Fixes #4912

Description

Screenshot from 2024-05-14 15-37-03

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

Copy link
Contributor

@bilalesi bilalesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 48.00%. Comparing base (932637c) to head (738cb9c).
Report is 1 commits behind head on develop.

Files Patch % Lines
.../shared/components/IDResolution/ResponseViewer.tsx 16.66% 5 Missing ⚠️
src/shared/containers/ResourceViewContainer.tsx 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1536      +/-   ##
===========================================
- Coverage    48.00%   48.00%   -0.01%     
===========================================
  Files          251      252       +1     
  Lines        11565    11576      +11     
  Branches      2709     2714       +5     
===========================================
+ Hits          5552     5557       +5     
- Misses        5980     5986       +6     
  Partials        33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dinika Dinika merged commit 39df20f into develop May 14, 2024
1 check passed
@Dinika Dinika deleted the 4912/validation-error-when-updating-resources branch May 14, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants