Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F4089: Fullscreen toggle appearance #1356

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

bilalesi
Copy link
Contributor

Fixes #BlueBrain/nexus#4089

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@bilalesi bilalesi self-assigned this Jul 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1356 (cd56610) into develop (1a6d489) will increase coverage by 0.05%.
The diff coverage is 78.10%.

@@             Coverage Diff             @@
##           develop    #1356      +/-   ##
===========================================
+ Coverage    47.76%   47.82%   +0.05%     
===========================================
  Files          241      243       +2     
  Lines        10714    10716       +2     
  Branches      2505     2515      +10     
===========================================
+ Hits          5118     5125       +7     
+ Misses        5564     5559       -5     
  Partials        32       32              
Files Changed Coverage Δ
...red/components/ResourceEditor/useEditorTooltip.tsx 3.80% <0.00%> (-0.80%) ⬇️
...rGraphFlowContent/DataExplorerGraphFlowContent.tsx 91.66% <ø> (ø)
src/subapps/dataExplorer/ProjectSelector.tsx 96.96% <ø> (ø)
...rc/shared/components/ResourceEditor/editorUtils.ts 18.08% <19.23%> (+0.69%) ⬆️
src/subapps/dataExplorer/PredicateSelector.tsx 96.52% <50.00%> (+0.02%) ⬆️
src/utils/validUrl.ts 38.46% <50.00%> (ø)
...pps/dataExplorer/DataExplorerCollapsibleHeader.tsx 98.21% <98.21%> (ø)
...as/DataExplorerGraphFlow/DateExplorerGraphFlow.tsx 94.64% <100.00%> (+0.76%) ⬆️
src/shared/components/Icons/FilterIcon.tsx 100.00% <100.00%> (ø)
...rc/shared/components/ResourceEditor/CodeEditor.tsx 100.00% <100.00%> (ø)
... and 5 more

... and 71 files with indirect coverage changes

@bilalesi bilalesi merged commit e080a23 into develop Jul 28, 2023
1 check passed
@bilalesi bilalesi deleted the f-4089/fullscreen-toggle-appearance branch July 28, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants