Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F4085: Warning not resolvable link #1349

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

bilalesi
Copy link
Contributor

Fixes #BlueBrain/nexus#4085

Description

Currently, when the user browse the JSON payload and hovers on an ID that cannot be resolved, we run a global search by ID on all projects the user can read. Then we show the list of matches. While this is useful, it hides the fact that the link in the user payload is broken in the context of the current project, it would be useful to draw the attention of the user on it.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@bilalesi bilalesi requested a review from smitfire July 25, 2023 14:46
@bilalesi bilalesi self-assigned this Jul 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #1349 (43f43ea) into develop (2b0a5e6) will decrease coverage by 0.16%.
Report is 1 commits behind head on develop.
The diff coverage is 4.16%.

@@             Coverage Diff             @@
##           develop    #1349      +/-   ##
===========================================
- Coverage    47.94%   47.79%   -0.16%     
===========================================
  Files          243      243              
  Lines        10721    10761      +40     
  Branches      2518     2526       +8     
===========================================
+ Hits          5140     5143       +3     
- Misses        5548     5585      +37     
  Partials        33       33              
Files Changed Coverage Δ
...red/components/ResourceEditor/useEditorTooltip.tsx 4.00% <4.16%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

@bilalesi bilalesi merged commit d0600be into develop Jul 28, 2023
1 check passed
@bilalesi bilalesi deleted the f-4085/warning-not-resolvable-link branch July 28, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants