Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Error resource view #1338

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Hotfix: Error resource view #1338

merged 2 commits into from
Jul 18, 2023

Conversation

bilalesi
Copy link
Contributor

Fixes #

Description

There was an error in the resource view container, I captured it when i did some test,
I make this fix related to checking the primitive type (string, array) of the View type in @types property

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@bilalesi bilalesi requested a review from Dinika July 18, 2023 07:48
@bilalesi bilalesi self-assigned this Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #1338 (4c42060) into develop (6c0a3c3) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #1338      +/-   ##
===========================================
+ Coverage    47.79%   47.80%   +0.01%     
===========================================
  Files          241      241              
  Lines        10699    10705       +6     
  Branches      2501     2507       +6     
===========================================
+ Hits          5114     5118       +4     
- Misses        5554     5555       +1     
- Partials        31       32       +1     
Impacted Files Coverage Δ
...shared/containers/ResourceViewActionsContainer.tsx 55.38% <66.66%> (+0.54%) ⬆️

@bilalesi bilalesi merged commit 88f6d43 into develop Jul 18, 2023
1 check passed
@bilalesi bilalesi deleted the hotfix/error-resource-view branch July 18, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants