Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Fix back arrow location #1332

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

bilalesi
Copy link
Contributor

Fixes #
It's an autocomplete issue, when auto import the library, location was not imported from useLocation
so in this PR, i fixed the location object import

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@bilalesi bilalesi requested a review from Dinika July 17, 2023 09:08
@bilalesi bilalesi self-assigned this Jul 17, 2023
@@ -13,6 +13,7 @@ import {
const useNavigationStackManager = () => {
const dispatch = useDispatch();
const history = useHistory();
const location = useLocation();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o wow! I'm surprised we didn't catch it before.

@codecov-commenter
Copy link

Codecov Report

Merging #1332 (669935c) into develop (53878fa) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1332      +/-   ##
===========================================
+ Coverage    47.67%   47.68%   +0.01%     
===========================================
  Files          241      241              
  Lines        10666    10667       +1     
  Branches      2489     2489              
===========================================
+ Hits          5085     5087       +2     
+ Misses        5550     5549       -1     
  Partials        31       31              
Impacted Files Coverage Δ
...orerGraphFlowNavigationStack/useNavigationStack.ts 91.66% <100.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

@bilalesi bilalesi merged commit 7ccdb27 into develop Jul 17, 2023
1 check passed
@bilalesi bilalesi deleted the hotfix/fix-back-arrow-location branch July 17, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants