Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BBPBGLIB-1127] Remove SpikeWriter.mod and out.dat #123

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

jorblancoa
Copy link
Collaborator

@jorblancoa jorblancoa commented Feb 12, 2024

Context

After the deprecation of BlueConfig files, out.dat is not generated anymore.
Remove the SpikeWriter mod file and the code that was handling the old out.dat spike file.

Review

  • PR description is complete
  • Coding style (imports, function length, New functions, classes or files) are good
  • Unit/Scientific test added
  • Updated Readme, in-code, developer documentation

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@jorblancoa jorblancoa marked this pull request as ready for review February 12, 2024 15:58
@bbpbuildbot
Copy link

@jorblancoa jorblancoa merged commit 975fb7c into main Feb 13, 2024
3 checks passed
@jorblancoa jorblancoa deleted the jblanco/remove_spikewriter branch February 13, 2024 10:06
atemerev pushed a commit that referenced this pull request Feb 13, 2024
## Context
After the deprecation of BlueConfig files, out.dat is not generated
anymore.
Remove the SpikeWriter mod file and the code that was handling the old
out.dat spike file.

## Review
* [x] PR description is complete
* [x] Coding style (imports, function length, New functions, classes or
files) are good
* [ ] Unit/Scientific test added
* [ ] Updated Readme, in-code, developer documentation
atemerev pushed a commit that referenced this pull request Feb 27, 2024
## Context
After the deprecation of BlueConfig files, out.dat is not generated
anymore.
Remove the SpikeWriter mod file and the code that was handling the old
out.dat spike file.

## Review
* [x] PR description is complete
* [x] Coding style (imports, function length, New functions, classes or
files) are good
* [ ] Unit/Scientific test added
* [ ] Updated Readme, in-code, developer documentation
WeinaJi pushed a commit that referenced this pull request Oct 14, 2024
## Context
After the deprecation of BlueConfig files, out.dat is not generated
anymore.
Remove the SpikeWriter mod file and the code that was handling the old
out.dat spike file.

## Review
* [x] PR description is complete
* [x] Coding style (imports, function length, New functions, classes or
files) are good
* [ ] Unit/Scientific test added
* [ ] Updated Readme, in-code, developer documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants