Remove SynapseReader.mod and SynReaderNRN #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WeinaJi
force-pushed
the
weji/clean_synloader
branch
from
07c1e52
to
183042e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jorblancoa
previously approved these changes
Feb 8, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jorblancoa
approved these changes
Feb 9, 2024
This comment has been minimized.
This comment has been minimized.
WeinaJi
force-pushed
the
weji/clean_synloader
branch
from
c037a2e
to
1a20413
Compare
|
Logfiles from GitLab pipeline #192506 (:white_check_mark:) have been uploaded here! Status and direct links: |
atemerev
pushed a commit
that referenced
this pull request
Feb 13, 2024
## Context After removing BlueConfig, we only support SONATA edges files loaded via `libsonata` API. This PR removes the synpase loaders that were used to support non-SONATA files. ## Scope Remove `SynapseReader.mod`. In `synapse_reader.py`, remove class `SynReaderNRN` which was used to load non-SONATA .h5 files via `HDF5Reader`. ## Testing Remove the test for `SynReaderNRN` ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [x] Updated Readme, in-code, developer documentation
atemerev
pushed a commit
that referenced
this pull request
Feb 27, 2024
## Context After removing BlueConfig, we only support SONATA edges files loaded via `libsonata` API. This PR removes the synpase loaders that were used to support non-SONATA files. ## Scope Remove `SynapseReader.mod`. In `synapse_reader.py`, remove class `SynReaderNRN` which was used to load non-SONATA .h5 files via `HDF5Reader`. ## Testing Remove the test for `SynReaderNRN` ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [x] Updated Readme, in-code, developer documentation
WeinaJi
added a commit
that referenced
this pull request
Oct 14, 2024
## Context After removing BlueConfig, we only support SONATA edges files loaded via `libsonata` API. This PR removes the synpase loaders that were used to support non-SONATA files. ## Scope Remove `SynapseReader.mod`. In `synapse_reader.py`, remove class `SynReaderNRN` which was used to load non-SONATA .h5 files via `HDF5Reader`. ## Testing Remove the test for `SynReaderNRN` ## Review * [x] PR description is complete * [x] Coding style (imports, function length, New functions, classes or files) are good * [ ] Unit/Scientific test added * [x] Updated Readme, in-code, developer documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After removing BlueConfig, we only support SONATA edges files loaded via
libsonataAPI. This PR removes the synpase loaders that were used to support non-SONATA files.Scope
Remove
SynapseReader.mod.In
synapse_reader.py, remove classSynReaderNRNwhich was used to load non-SONATA .h5 files viaHDF5Reader.Testing
Remove the test for
SynReaderNRNReview