Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when CI is run. #963

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Fix when CI is run. #963

merged 2 commits into from
Feb 15, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Feb 15, 2024

The tests should run for every PR and when merged into the main or v2.x branch. Docs should be published only when merging into v2.x (for now).

We've removed release/** since we don't have those. It also removes ci_test because I haven't seen anyone test the CI that way, git commit --allow-empty can be used instead.

The tests should run for every PR and when merged into the main or
`v2.x` branch.

Docs should be published only when merging into `v2.x` (for now).
@1uc
Copy link
Collaborator Author

1uc commented Feb 15, 2024

See #961.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f32d186) 84.55% compared to head (11b7b61) 84.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #963   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files          86       86           
  Lines        5220     5220           
=======================================
  Hits         4414     4414           
  Misses        806      806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review February 15, 2024 10:37
@1uc 1uc merged commit aa43041 into master Feb 15, 2024
36 checks passed
@1uc 1uc deleted the 1uc/ci-conditions branch February 15, 2024 14:28
1uc added a commit that referenced this pull request Feb 16, 2024
The tests should run for every PR and when merged into the main or
`v2.x` branch. Docs should be published only when merging into `v2.x`
(for now).
@1uc 1uc mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants