Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move selection related tests. #876

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Move selection related tests. #876

merged 1 commit into from
Nov 30, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 29, 2023

Part of reorganizing the tests requires grouping tests. One such group is anything related to selections, e.g. column, row or point selections, hyperslabs, etc.

This commit only moves code from one file to the next without any changes.

Part of reorganizing the tests requires grouping tests. One such group
is anything related to selections, e.g. column, row or point selections,
hyperslabs, etc.

This commit only moves code from one file to the next without any
changes.
@1uc
Copy link
Collaborator Author

1uc commented Nov 29, 2023

See documentation in #871 for the general direction we're heading towards.

@1uc 1uc marked this pull request as ready for review November 29, 2023 18:10
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9415a7c) 84.89% compared to head (011c70a) 84.89%.
Report is 2 commits behind head on master.

Files Patch % Lines
tests/unit/test_high_five_selection.cpp 99.19% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   84.89%   84.89%           
=======================================
  Files          70       71    +1     
  Lines        5090     5090           
=======================================
  Hits         4321     4321           
  Misses        769      769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc requested a review from matz-e November 30, 2023 08:59
@1uc 1uc merged commit cdf79df into master Nov 30, 2023
36 checks passed
@1uc 1uc deleted the 1uc/reorg-selection-tests branch November 30, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants