-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible std::string
s.
#744
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
+ Coverage 84.68% 84.73% +0.04%
==========================================
Files 68 69 +1
Lines 4812 5043 +231
==========================================
+ Hits 4075 4273 +198
- Misses 737 770 +33
☔ View full report in Codecov by Sentry. |
648f84e
to
b597762
Compare
Things to discuss:
|
b597762
to
84143ca
Compare
84143ca
to
13e6a74
Compare
e35ea57
to
796e529
Compare
796e529
to
233f773
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a glance over this, looks good.
This commit implements serializing `std::string` to both variable (the default) and fixed length HDF5 strings.
233f773
to
8bfa11f
Compare
This PR outlines how one could read and write
std::string
and containers ofstd::string
into/from fixed or variable length HDF5 strings.