Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate FixedLenStringArray. #906

Closed
1uc opened this issue Dec 22, 2023 · 1 comment
Closed

Deprecate FixedLenStringArray. #906

1uc opened this issue Dec 22, 2023 · 1 comment
Labels
v3 Anything that needs to be resolved before `v3`.

Comments

@1uc
Copy link
Collaborator

1uc commented Dec 22, 2023 •
edited
Loading

The FixedLenStringArray defined here:

HighFive/include/highfive/H5DataType.hpp

Line 355 in 04ae650

class FixedLenStringArray {

might be a target for deprecation in 2.x.0 and removal in 3.0.0. It only works with compile-time constant fixed-length strings. When dealing with std::strings we now have better options, see #744. Since FixedLenStringArray can't avoid copies, one might as well copy into containers of std::strings. Or write from a raw pointer, if memory is already correctly arranged.
@1uc 1uc added the v3 Anything that needs to be resolved before `v3`. label Dec 22, 2023
@1uc 1uc mentioned this issue Dec 22, 2023
Closed
@1uc
Copy link
Collaborator Author

1uc commented Feb 12, 2024

Deprecated and gone. Please consult the migration guide; and create an issue if there's still open questions.

@1uc 1uc closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v3 Anything that needs to be resolved before `v3`.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1uc