Support for Armadillo?

[berquist]

Armadillo has been brought up once in #3. For my own usage I've written an interface that needs cleaning up but does work, though I haven't benchmarked it yet.

The annoying thing about Armadillo is dealing with the column-major layout. Their own HDF5 interface writes out as though the underlying memory is row-major, so the file isn't trivially usable from...any other code, really. This interface does the obvious right thing for row vectors, column vectors, and matrices in terms of shapes. Cubes are a little weird (from docs):

Cube data is stored as a set of slices (matrices) stored contiguously within memory. Within each slice, elements are stored with column-major ordering (ie. column by column)

Because iterating over the slice index is typical, I decided to put the slice index first.

Is this something the project would be interested in adding?

[tdegeus]

I'm not interested in adding it, but would be happy to review. The H5Easy API is a good place to add this first. There are already many templates: Eigen, xtensor, ImageCV

[pramodk]

@berquist: if you have working draft, please open a pull request and someone from our side would be happy to review and provide feedback. Thanks in advance!

(Edit: I will close this ticket. We can continue discussion when you have PR or feel free to reopen this if necessary).

[berquist]

#586 completely changed the interface in H5Converter_misc.hpp. I had written data_converters and inspectors for each class. Do I switch from data_converter to Reader and Writer, or is it something else?

[1uc]

@berquist Most of the code has been concentrated in the inspector<T>. Hopefully the code for boost::multi_array is helpful, see

HighFive/include/highfive/bits/H5Inspector_misc.hpp

Line 697 in 64b7ad9

struct inspector<boost::multi_array<T, Dims>> {

I think you'd move most of you code into the inspector and leave the Reader and Writer alone. In order to improve the way we handle strings, we'll probably end up reworking the Reader and Writer, see #744 for a sketch of what we intend to do; and if it affects you.