Support Capistrano 3.7.1?

[csdougliss]

No description provided.

[Bladrak]

Can you be more explicit? What is not supported?

[csdougliss]

The error I had seems to have dissappeared, But I do see this:

Skipping task `rsync:check'.
Capistrano tasks may only be invoked once. Since task `rsync:check' was previously invoked, invoke("rsync:check") at /Users/ccarnell/.gem/ruby/2.0.0/gems/capistrano-rsync-bladrak-1.3.8/lib/capistrano/rsync.rb:124 will be skipped.
If you really meant to run this task again, first call Rake::Task["rsync:check"].reenable
THIS BEHAVIOR MAY CHANGE IN A FUTURE VERSION OF CAPISTRANO. Please join the conversation here if this affects you.
https://github.com/capistrano/capistrano/issues/1686
Skipping task `rsync:check'.
Capistrano tasks may only be invoked once. Since task `rsync:check' was previously invoked, invoke("rsync:check") at /Users/ccarnell/.gem/ruby/2.0.0/gems/capistrano-rsync-bladrak-1.3.8/lib/capistrano/rsync.rb:124 will be skipped.
If you really meant to run this task again, first call Rake::Task["rsync:check"].reenable
THIS BEHAVIOR MAY CHANGE IN A FUTURE VERSION OF CAPISTRANO. Please join the conversation here if this affects you.
https://github.com/capistrano/capistrano/issues/1686

This happens twice

[Bladrak]

Ok, seems like a warning. I'll keep this issue open to take a look at it when I've got the time then.

[csdougliss]

@Bladrak

I also see:

[Deprecation Notice] `set :scm, :rsync` is deprecated.
To ensure this custom SCM will work with future versions of Capistrano,
please upgrade it to a version that uses the new SCM plugin mechanism
documented here:

http://capistranorb.com/documentation/advanced-features/custom-scm

[Bladrak]

Thanks, I'll take a look at that as well :)

[NairolfL]

Hello,
Any news on this issue ?

Thank you

[Bladrak]

Sorry @NairolfL didn't get much time lately to work on OSS. If anyone wants to take this up, I'd be happy to review the PR.

[caryp]

I think there was a breaking change in Cap v3.7.0. They now support an “SCM plugins” architecture: http://capistranorb.com/documentation/advanced-features/custom-scm/

[noniq]

I wrote a simple plugin for deploying via rsync in Capistrano 3.7+ (using the new “SCM plugins architecture”): https://gist.github.com/noniq/f73e7eb199a4c2ad519c6b5e2ba5b0df

I might create a gem out of this if I find the time. In the meantime feel free to adapt & reuse.

[caryp]

Very cool. Thanks for sharing!

[Bladrak]

Nice @noniq :) If you want to use this repo for it, let me know!

[noniq]

Thanks for the offer! It’s a rather breaking set of changes though, so I’m not sure if it’s a good idea to reuse this existing project for it, especially since I’m assuming that there are still plenty of people using Capistrano < 3.7 together with the current version of this project.

I’ll think a bit more about it, happy to hear other thoughts on that, too!

[Bladrak]

We can manage through the gem versioning I think for the breaking changes. It's time this repo embraces the updates of Capistrano ;) Let me know anyway, happy to talk about it.

[deatharse]

@noniq Just tested out your gist works great. In case is helpful for anyone else, our usage was to deploy tags or branches and noticed issues due to the inclusion of origin/ in update_local_cache. We decided to remove this so we could pass in a tag name or when passing a branch we pass it as origin/my_branch.

[infovore]

Hello - I've wrapped up @noniq's excellent gist into a straight-up Capistrano Plugin, which is available here. I had no idea how best to name it, so named it unimaginatively, and indicated in the readme that it's for 3.7.1+ plugin syntax.

I've also included examples of use, especially how to hook local build processes into it, which is how I'm using it. It's on rubygems atm; I am happy to change/alter anything at request, or, indeed, receive feedback over at my Issues page. I've added @noniq as a listed author. Hope that isn't overstepping any bounds.

[noniq]

@infovore Great, thanks a lot! 🎉