Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1.4: Create wallet - specs & progress #62

Open
GBKS opened this issue Jul 26, 2023 · 5 comments
Open

Milestone 1.4: Create wallet - specs & progress #62

GBKS opened this issue Jul 26, 2023 · 5 comments
Assignees
Labels

Comments

@GBKS
Copy link
Contributor

GBKS commented Jul 26, 2023

This is a tracker/discssion issue for the 1.4 milestone (design docs).

Goal is to add a wallet creation to the application. In milestone 1.3, we added wallet import, now we also let users create wallets. This includes a prompt during the first use experience, and a complex flow to guide users through creating different types of wallets. We will start simple, but need to ensure to keep future updates in mind, like creating multi-key wallets with several fallback paths.

Addition:

  • User flow for creating various types of wallets (1+ keys, external, descriptor, miniscript, etc)

Specs:
We really need to create specs for which technical features will be supported here to inform the design

@GBKS
Copy link
Contributor Author

GBKS commented Aug 4, 2023

#27 is an older issue on this topic form our design discovery in September 2022. Closing that one now in favor of this new one here that is in-line with our milestone schedule.

@GBKS GBKS added define and removed discover labels Feb 8, 2024
@GBKS GBKS moved this to In Progress in Bitcoin Core App Feb 8, 2024
@stackingsaunter
Copy link
Contributor

stackingsaunter commented Feb 20, 2024

@GBKS I think you can assign me and @rabbitholiness

My updates from this week can be seen here

image

Regular

CleanShot 2024-02-20 at 22 36 15@2x

CleanShot 2024-02-20 at 22 36 43@2x

CleanShot 2024-02-20 at 22 36 53@2x

Multi-key

CleanShot 2024-02-20 at 22 37 24@2x

CleanShot 2024-02-20 at 22 37 38@2x

CleanShot 2024-02-20 at 22 38 39@2x

CleanShot 2024-02-20 at 22 38 50@2x

Custom

CleanShot 2024-02-20 at 22 39 10@2x

CleanShot 2024-02-20 at 22 39 43@2x

CleanShot 2024-02-20 at 22 42 15@2x

Main questions now

  • Should we allow to import keys for Multisig by uploading a file? (I think it's a bad practice)
  • Options in Custom wallet needs to be consulted with devs
  • Since hardware wallet and view-only is more of import than creation, I didn't include them here. Is this a good choice?

@stackingsaunter
Copy link
Contributor

stackingsaunter commented Apr 2, 2024

I iterated a bit on the flows and recorded a video going through the prototype. Most changed in how keys are added to the multisig, I tried to implement the idea we discussed on last call.

Link to Figma designs

I think the designs need:

  1. Design review on key adding flows
  2. General technical review, especially for Custom flow

Prototypes

  1. Singlesig
  2. Multisig
  3. Custom

New Multisig + Custom designs

image

image

image

image

image

image

image

@stackingsaunter
Copy link
Contributor

stackingsaunter commented Jun 3, 2024

Here's handoff of Create single-sig wallet flow after round of user testing:

Figma file

image

image

image

image

image

image

image

image

@GBKS
Copy link
Contributor Author

GBKS commented Sep 20, 2024

This is a very big issue. Now that wallet creation is implemented, both from onboarding and from within the app, we should try to wrap this one up and create smaller issues for anything still outstanding. I'll put that on my low-priority list, unless someone else wants to take it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

2 participants